Mailing List Archive: ModPerl: Dev

silence unused warnings

Index | Next | Previous | View Threaded

torsten.foertsch at gmx

Jun 30, 2008, 2:44 AM

Post #1 of 4 (376 views)
Permalink

silence unused warnings

Hi,

this patch silence a few warnings about unused variables and unused return
codes. It is against the threading branch but is applyable with offsets to
trunk. Is it OK to apply it?

Torsten

Attachments:

silence_unused.diff (5.34 KB)

pgollucci at p6m7g8

Jun 30, 2008, 9:36 AM

Post #2 of 4 (365 views)
Permalink

Re: silence unused warnings [In reply to]

Torsten Foertsch wrote:
> Hi,
>
> this patch silence a few warnings about unused variables and unused return
> codes. It is against the threading branch but is applyable with offsets to
> trunk. Is it OK to apply it?
Looks good to me on both branch and trunk.

+1

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe[at]perl.apache.org
For additional commands, e-mail: dev-help[at]perl.apache.org

torsten.foertsch at gmx

Jun 30, 2008, 9:54 AM

Post #3 of 4 (359 views)
Permalink

Re: silence unused warnings [In reply to]

On Mon 30 Jun 2008, Philip M. Gollucci wrote:
> > this patch silence a few warnings about unused variables and unused
> > return codes. It is against the threading branch but is applyable with
> > offsets to trunk. Is it OK to apply it?
>
> Looks good to me on both branch and trunk.

Committed revision 672819.

Torsten

--
Need professional mod_perl support?
Just hire me: torsten.foertsch[at]gmx.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe[at]perl.apache.org
For additional commands, e-mail: dev-help[at]perl.apache.org

gozer at ectoplasm

Jun 30, 2008, 10:11 AM

Post #4 of 4 (358 views)
Permalink

Re: silence unused warnings [In reply to]

Torsten Foertsch wrote:
> Hi,
>
> this patch silence a few warnings about unused variables and unused return
> codes. It is against the threading branch but is applyable with offsets to
> trunk. Is it OK to apply it?

Go right ahead, I had been sitting on an almost identical patch myself,
from when I last build with -Wall -Werror.

+1
--
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/

Attachments:

signature.asc (0.24 KB)

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com