Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: ModPerl: Dev

Re: svn commit: r672819 - in /perl/modperl/trunk: src/modules/perl/mod_perl.c src/modules/perl/modperl_env.c src/modules/perl/modperl_perl_global.c src/modules/perl/modperl_util.c xs/Apache2/Access/Apache2__Access.h xs/Apache2/Directive/Apache2__Directive

 

 

ModPerl dev RSS feed   Index | Next | Previous | View Threaded


gozer at ectoplasm

Jun 30, 2008, 10:13 AM

Post #1 of 3 (570 views)
Permalink
Re: svn commit: r672819 - in /perl/modperl/trunk: src/modules/perl/mod_perl.c src/modules/perl/modperl_env.c src/modules/perl/modperl_perl_global.c src/modules/perl/modperl_util.c xs/Apache2/Access/Apache2__Access.h xs/Apache2/Directive/Apache2__Directive

torsten[at]apache.org wrote:
> Author: torsten
> Date: Mon Jun 30 09:51:30 2008
> New Revision: 672819
>
> URL: http://svn.apache.org/viewvc?rev=672819&view=rev
> Log:
> silence some "unused" warnings
>
> Modified:
> perl/modperl/trunk/src/modules/perl/mod_perl.c
> perl/modperl/trunk/src/modules/perl/modperl_env.c
> perl/modperl/trunk/src/modules/perl/modperl_perl_global.c
> perl/modperl/trunk/src/modules/perl/modperl_util.c
> perl/modperl/trunk/xs/Apache2/Access/Apache2__Access.h
> perl/modperl/trunk/xs/Apache2/Directive/Apache2__Directive.h
>

Shouldn't this change have been applied to trunk/ and then svnmerged to
the threading/ branch ?

Otherwise, the next person to svnmerge will almost certainly get a nasty
merge conflict. It's also fixable after the fact with 'svnmerge block'.

--
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
Attachments: signature.asc (0.24 KB)


pgollucci at p6m7g8

Jun 30, 2008, 10:43 AM

Post #2 of 3 (555 views)
Permalink
Re: svn commit: r672819 - in /perl/modperl/trunk: src/modules/perl/mod_perl.c src/modules/perl/modperl_env.c src/modules/perl/modperl_perl_global.c src/modules/perl/modperl_util.c xs/Apache2/Access/Apache2__Access.h xs/Apache2/Directive/Apache2__Directive [In reply to]

Philippe M. Chiasson wrote:
> torsten[at]apache.org wrote:
>> Author: torsten
>> Date: Mon Jun 30 09:51:30 2008
>> New Revision: 672819
>>
>> URL: http://svn.apache.org/viewvc?rev=672819&view=rev
>> Log:
>> silence some "unused" warnings
>>
>> Modified:
>> perl/modperl/trunk/src/modules/perl/mod_perl.c
>> perl/modperl/trunk/src/modules/perl/modperl_env.c
>> perl/modperl/trunk/src/modules/perl/modperl_perl_global.c
>> perl/modperl/trunk/src/modules/perl/modperl_util.c
>> perl/modperl/trunk/xs/Apache2/Access/Apache2__Access.h
>> perl/modperl/trunk/xs/Apache2/Directive/Apache2__Directive.h
>>
>
> Shouldn't this change have been applied to trunk/ and then svnmerged to
> the threading/ branch ?
>
> Otherwise, the next person to svnmerge will almost certainly get a nasty
> merge conflict. It's also fixable after the fact with 'svnmerge block'.
>
Does that matter until everyone updates clients to 1.5.x ?


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe[at]perl.apache.org
For additional commands, e-mail: dev-help[at]perl.apache.org


gozer at ectoplasm

Jun 30, 2008, 10:48 AM

Post #3 of 3 (552 views)
Permalink
Re: svn commit: r672819 - in /perl/modperl/trunk: src/modules/perl/mod_perl.c src/modules/perl/modperl_env.c src/modules/perl/modperl_perl_global.c src/modules/perl/modperl_util.c xs/Apache2/Access/Apache2__Access.h xs/Apache2/Directive/Apache2__Directive [In reply to]

Philip M. Gollucci wrote:
> Philippe M. Chiasson wrote:
>> torsten[at]apache.org wrote:
>>> Author: torsten
>>> Date: Mon Jun 30 09:51:30 2008
>>> New Revision: 672819
>>>
>>> URL: http://svn.apache.org/viewvc?rev=672819&view=rev
>>> Log:
>>> silence some "unused" warnings
>>>
>>> Modified:
>>> perl/modperl/trunk/src/modules/perl/mod_perl.c
>>> perl/modperl/trunk/src/modules/perl/modperl_env.c
>>> perl/modperl/trunk/src/modules/perl/modperl_perl_global.c
>>> perl/modperl/trunk/src/modules/perl/modperl_util.c
>>> perl/modperl/trunk/xs/Apache2/Access/Apache2__Access.h
>>> perl/modperl/trunk/xs/Apache2/Directive/Apache2__Directive.h
>>>
>> Shouldn't this change have been applied to trunk/ and then svnmerged to
>> the threading/ branch ?
>>
>> Otherwise, the next person to svnmerge will almost certainly get a nasty
>> merge conflict. It's also fixable after the fact with 'svnmerge block'.
>>
> Does that matter until everyone updates clients to 1.5.x ?

Not sure what svn 1.5.x changes in this case ?

--
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
Attachments: signature.asc (0.24 KB)

ModPerl dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.